Open
Conversation
Author
|
@stefanneculai any feedback here? |
viveksingh801
pushed a commit
to vivek-accolite-801/wysiwyg-editor-php-sdk
that referenced
this pull request
Feb 15, 2023
Contributor
|
@jacovdbergh Sorry for the delayed response. Both of the URL formats are support by S3, I think. Though I think we keep it consistent - will include this one. Thanks |
Contributor
|
@harasunu-narayan - Added as a part of #30 |
Author
|
Haha forgot about this, but thanks :D |
harasunu-narayan
added a commit
that referenced
this pull request
Jul 12, 2023
* BUGFIX: Obj echo issue fix - added json_encode * PRE_RELEASE: Increment Version Number * REVERT: Version Number * PR: Remove BraintreeException #23 * PR: Add PHP version and extension requirementss #24 * PR: Correct URL for other regions #27 * Update to v4.1.0 --------- Co-authored-by: Vivek <vivek.singh@accolitedigital.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buckets other than us-east-1 incorrectly had
s3-prepended, where it should have beens3.https://s3-af-south-1.amazonaws.com/bucket-name
which should be
https://s3.af-south-1.amazonaws.com/bucket-name