Skip to content

Conversation

@mback2k
Copy link
Contributor

@mback2k mback2k commented Apr 11, 2025

Description:

Support livestreaming based on the work described in #343:

Related issue (if applicable): fixes #343

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@mback2k
Copy link
Contributor Author

mback2k commented Apr 11, 2025

For now this PR just serves as a status tracker for the example shown in #343 (comment).

@mback2k
Copy link
Contributor Author

mback2k commented Apr 18, 2025

@fronzbot hey, do you think this could be merged without tests for the livestreaming part or do you want a mock for that?

@mback2k mback2k changed the title Work in Progress Draft - Support for Livestreaming Support for Livestreaming via local TCP proxy server Apr 18, 2025
mback2k referenced this pull request in mback2k/home-assistant Apr 18, 2025
@fronzbot
Copy link
Owner

My preference is for tests to be included for new methods/classes. Far too often something has changed on Blink's end resulting in a library change that borks some code that we weren't unittesting. Better to get in front of that IMO.

Is this ready for review? I see you changed the title but it's still marked as a draft.

@mback2k
Copy link
Contributor Author

mback2k commented Apr 20, 2025

It is missing tests right now, but I will try to add some for the new API. Not sure about the livestream itself though.

@fronzbot
Copy link
Owner

fronzbot commented Jun 6, 2025

Hi @mback2k - this has been open for awhile now and still marked as a Draft. Is this ready for review yet?

@mback2k
Copy link
Contributor Author

mback2k commented Jun 6, 2025

Hi @mback2k - this has been open for awhile now and still marked as a Draft. Is this ready for review yet?

I am sorry, I was sick recently. I will try to get back to this soon, but for now tests are still missing and the stream connection is also not fully reliable yet, I guess because not all parameters in the authentication frames ware correctly decoded yet.

@mback2k
Copy link
Contributor Author

mback2k commented Jul 6, 2025

@fronzbot I have got a stable MPEG-TS streaming implementation now and also tests for the blinkpy API. I am still working on tests for the internals of the BlinkLiveStream class, but I spotted that the coverage CI/CD job fails due to some token issue: https://github.com/fronzbot/blinkpy/actions/runs/16103190750/job/45435025323?pr=1051

@mback2k mback2k deleted the branch fronzbot:dev July 7, 2025 18:31
@mback2k mback2k closed this Jul 7, 2025
@mback2k mback2k deleted the dev branch July 7, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_liveview() returns a immis protocol link

3 participants