Open
Conversation
…. Using .format, fixed some typos
…ype as required for Python 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Here's a PR to add Python 3 support to SIET.
Marked WIP because I still want to test some of the more invasive features to make sure everything works. The TFTP server logic and all syntax has been made to support both Python 2 and 3. I think the hex encode/decode logic can be cleaned up even further because the Python 3 method is backwards compatible with Python 2.
Most of what I've been able to test so far has been config file retrieval. I have a Cisco device to experiment with but I don't think it supports SMI.
Happy to answer any questions there may be. In the future, we might want to consider dropping Python 2 support entirely but I think that's a way off yet.