Make it work with react native 0.51 #13
Conversation
infostreams
changed the title
| "main": "dist/react-intl-native.js", | ||
| "jsnext:main": "dist/react-intl-native.es2015.js", | ||
| "main": "src/index.js", | ||
| "jsnext:main": "src/index.js", |
There was a problem hiding this comment.
jsnext:main is deprecated. I don't think we should use it. If we need an ES2015 version to be explicitly defined, it should be under module.
| "main": "dist/react-intl-native.js", | ||
| "jsnext:main": "dist/react-intl-native.es2015.js", | ||
| "main": "src/index.js", | ||
| "jsnext:main": "src/index.js", | ||
| "scripts": { | ||
| "prebuild": "rimraf dist", | ||
| "build": "rollup-babel-lib-bundler -f cjs,es6 src/index.js", |
There was a problem hiding this comment.
Since it's directly referencing the source, we don't need the rollup builds any more. I'm not sure if it's in the scope of the pull request though.
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| [](https://travis-ci.org/frostney/react-intl-native) [](https://david-dm.org/frostney/react-intl-native) [](https://david-dm.org/frostney/react-intl-native#info=devDependencies) [](https://codecov.io/github/frostney/react-intl-native?branch=master) | |||
|
|
|||
| `react-intl` convinience components for React Native | |||
| `react-intl` convenience components for React Native | |||
| @@ -10,6 +11,21 @@ const FormattedDate = props => ( | |||
|
|
|||
| FormattedDate.propTypes = { | |||
| style: PropTypes.any, | |||
| localeMatcher: PropTypes.oneOf(['best fit', 'lookup']), | |||
|
Thanks! So shall I remove |
|
In my opinion removing the build process and using the ES2015 modules should be part of a separate pull request only scoped on updating the build process. I would like to have Please see as my comments as nitpicks only. It would not block the merging in, once the test passes 🙂 |
Did not work (at all) before