Open
Conversation
…strayphotons into feature/mac-arm64-support
ricardopieper
commented
Feb 8, 2026
|
|
||
| #include "console/Console.hh" | ||
|
|
||
| #include <unistd.h> |
Author
There was a problem hiding this comment.
Otherwise it does not find execl and fork
ricardopieper
commented
Feb 8, 2026
| */ | ||
| size_t Add(const Event &event, size_t transactionId = 0) const; | ||
| size_t Add(const AsyncEvent &event) const; | ||
| uint64_t Add(const Event &event, uint64_t transactionId = 0) const; |
Author
There was a problem hiding this comment.
The impl changed but the interface didn't. No difference on linux but it is a compilation error for me.
ricardopieper
commented
Feb 8, 2026
| VK_EXT_CALIBRATED_TIMESTAMPS_EXTENSION_NAME, | ||
| VK_EXT_SHADER_VIEWPORT_INDEX_LAYER_EXTENSION_NAME, | ||
| }; | ||
| "VK_KHR_portability_subset"}; |
Author
There was a problem hiding this comment.
The const exists but for some reason compilation fails because it... does not exist? idk
ricardopieper
commented
Feb 8, 2026
| set(PROJECT_ROOT_DIR ${CMAKE_CURRENT_SOURCE_DIR}) | ||
| set(PROJECT_OUTPUT_DIR ${CMAKE_CURRENT_SOURCE_DIR}/bin) | ||
| set(CMAKE_INSTALL_RPATH $ORIGIN) | ||
| if(APPLE) |
Author
There was a problem hiding this comment.
MacOS does not like the $ORIGIN
Author
There was a problem hiding this comment.
And the /usr/local/lib is so that it finds the vulkan dylib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not meant to be merged, just a reference of what I'm doing to make it run on macs.