Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the project from .NET 9 to .NET 10 and F# 9 to F# 10, while introducing several improvements to the computation expression builder and fiber implementation.
- Updated all projects to target .NET 10 and FSharp.Core 10.0.101 with preview language features enabled
- Enhanced the FIOBuilder with new
ReturnFromFinalandYieldFromFinalmembers for clearer final operation semantics - Fixed potential double-completion issue in
InternalFiber.Completemethod - Updated test dependencies and benchmark configurations
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/FSharp.FIO.Tests/FSharp.FIO.Tests.fsproj | Updated target framework, added preview language version, and upgraded test dependencies |
| src/FSharp.FIO/FSharp.FIO.fsproj | Updated target framework, added preview language version, and updated package paths |
| src/FSharp.FIO/DSL/Core.fs | Fixed double-completion logic in InternalFiber |
| src/FSharp.FIO/DSL/CE.fs | Added ReturnFromFinal/YieldFromFinal members and simplified Yield/YieldFrom implementations |
| src/FSharp.FIO.Lib/FSharp.FIO.Lib.fsproj | Updated target framework and FSharp.Core version |
| src/FSharp.FIO.App/FSharp.FIO.App.fsproj | Updated target framework and FSharp.Core version |
| examples/FSharp.FIO.Examples/FSharp.FIO.Examples.fsproj | Updated target framework and FSharp.Core version |
| examples/FSharp.FIO.Examples.App/FSharp.FIO.Examples.App.fsproj | Updated target framework and FSharp.Core version |
| benchmarks/FSharp.FIO.Benchmarks/Properties/launchSettings.json | Updated benchmark command-line arguments for broader coverage |
| benchmarks/FSharp.FIO.Benchmarks/FSharp.FIO.Benchmarks.fsproj | Updated target framework and FSharp.Core version |
| benchmarks/FSharp.FIO.Benchmarks.Plots/FSharp.FIO.Benchmarks.Plots.fsproj | Updated target framework and FSharp.Core version |
| .vscode/settings.json | Added setting to disable F# inlay hints |
| .github/workflows/test.yml | Updated CI workflow to use .NET 10 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to target .NET 10 and FSharp.Core 10 across all projects, enables F# language preview features, and introduces several improvements and fixes to the computation expression (CE) builder and internal fiber implementation. There are also updates to test dependencies, launch settings, and editor configuration.
.NET and F# Core version upgrades:
Updated all project files to target
net10.0instead ofnet9.0and to useFSharp.Coreversion10.0.101[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18].Added
<LangVersion>preview</LangVersion>to all project files to enable F# preview language features [1] [2] [3] [4] [5] [6] [7] [8].Computation Expression (CE) and Fiber improvements:
ReturnFromFinalandYieldFromFinalmembers to theFIOBuilder, clarifying the intent for final operations in computation expressions [1] [2].Yieldimplementation to useFIO.Succeeddirectly for improved clarity and consistency.YieldFromto return the effect directly.InternalFiber.Completeto avoid double-completion and handle already completed tasks more robustly.Test and tooling updates:
Microsoft.NET.Test.Sdk,FsCheck,xunit.runner.visualstudio) for improved reliability and compatibility.Editor and CI configuration:
These changes collectively modernize the codebase, improve developer experience, and enhance the reliability and maintainability of the computation expression infrastructure.