Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements performance optimizations and updates copyright information across the codebase. The main focus is on reducing garbage collection pressure through object pooling and improving concurrency handling.
Key changes:
- Introduced continuation stack pooling to reduce allocations
- Improved runtime disposal patterns and error handling
- Added new FIO operations (Retry, Timeout, AcquireRelease)
- Updated copyright year from 2025 to 2026 and removed nickname references
Reviewed changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/FSharp.FIO.Tests/RuntimeTests.fs | Updated copyright, changed Task.Result to GetAwaiter().GetResult(), added new keyword for runtime instantiation, added test for Fiber.Id uniqueness |
| tests/FSharp.FIO.Tests/PropertyTests.fs | Updated copyright, changed Task.Result to GetAwaiter().GetResult(), added new keyword for runtime instantiation |
| src/FSharp.FIO/Runtime/Runtime.fs | Updated copyright, added ContStackPool implementation for object pooling |
| src/FSharp.FIO/Runtime/DirectRuntime.fs | Updated copyright, integrated ContStackPool, improved concurrent effect error handling |
| src/FSharp.FIO/Runtime/CooperativeRuntime.fs | Updated copyright, integrated ContStackPool, added cancellation support, improved worker disposal, optimized channel operations |
| src/FSharp.FIO/Runtime/ConcurrentRuntime.fs | Updated copyright, integrated ContStackPool, added cancellation support, improved worker disposal, optimized channel operations |
| src/FSharp.FIO/Runtime.Tools/Monitor.fs | Updated copyright, refactored to non-destructive monitoring approach |
| src/FSharp.FIO/Runtime.Tools/DeadlockDetector.fs | Updated copyright, refactored to non-destructive monitoring, improved detection logic |
| src/FSharp.FIO/FSharp.FIO.fsproj | Updated version from 0.0.31-alpha to 0.0.32-alpha |
| src/FSharp.FIO/DSL/Ops.fs | Updated copyright |
| src/FSharp.FIO/DSL/Core.fs | Updated copyright, improved InternalFiber completion handling, added TryRescheduleBlockingWorkItems, fixed Fiber.Id property, added AcquireRelease/Retry/Timeout operations |
| src/FSharp.FIO/DSL/CE.fs | Updated copyright, changed TryFinally to use FIO effects, improved Using method type constraints |
| src/FSharp.FIO.Lib/Net/WebSockets.fs | Updated copyright |
| src/FSharp.FIO.Lib/Net/Sockets.fs | Updated copyright, added IDisposable implementation, improved null handling in Receive |
| src/FSharp.FIO.Lib/IO/FConsole.fs | Updated copyright |
| src/FSharp.FIO.App/App.fs | Updated copyright, improved ThreadPool configuration |
| examples/FSharp.FIO.Examples/Program.fs | Updated copyright, added new keyword for runtime instantiation throughout examples |
| examples/FSharp.FIO.Examples.App/Program.fs | Updated copyright, added ErrorHandlingWithRetryApp example |
| benchmarks/* | Updated copyright across all benchmark files, added new keyword for runtime instantiation, improved ThreadPool configuration |
| README.md | Updated personal URLs and references, removed outdated thesis link |
| LICENSE.md | Updated copyright year to 2026 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.