playing cards unicode symbols added for string representation#5
playing cards unicode symbols added for string representation#5Zhigal wants to merge 10 commits intofschlatt:mainfrom
Conversation
|
Hey @Zhigal , thanks for the PR. I didn't know those unicode cards exist. They're pretty cool. Unfortunately, there are a couple of issues. Mainly, the unicode characters don't always get rendered the same way and on this could lead to issues on some systems. I would prefer an option for the ascii renderer to use the unicode cards or letters. Second, the PR currently does not pass the tests for the ascii render mode because it they still expect the old card representation. Finally, this representation breaks the webserver html render mode because it uses the string representation of a card to determine the SVG card to use. If you have the time, it would be awesome if you could integrate those changes and resubmit the PR. |
|
Thanks for your answer @fschlatt. |
No description provided.