[MAINTENANCE] Adjust condition checks and assigments to array (kitodo#1731)

Co-authored-by: Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>

Author: beatrycze-volk

Classes/Command/HarvestCommand.php

@@ -99,7 +99,7 @@ public function configure(): void
 
     /**
      * Executes the command to index the given document to DB and SOLR.
-     * 
+     *
      * @access protected
      *
      * @param InputInterface $input The input parameters
@@ -109,7 +109,7 @@ public function configure(): void
      */
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $dryRun = $input->getOption('dry-run') != false ? true : false;
+        $dryRun = $input->getOption('dry-run') != false;
 
         $io = new SymfonyStyle($input, $output);
         $io->title($this->getDescription());

Classes/Command/ReindexCommand.php

@@ -113,7 +113,7 @@ public function configure(): void
      */
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $dryRun = $input->getOption('dry-run') != false ? true : false;
+        $dryRun = $input->getOption('dry-run') != false;
 
         $io = new SymfonyStyle($input, $output);
         $io->title($this->getDescription());

Classes/Common/Solr/SearchResult/ResultDocument.php

@@ -272,7 +272,7 @@ public function getHighlightsIds(): array
     {
         $highlightsIds = [];
         foreach ($this->highlights as $highlight) {
-            array_push($highlightsIds, $highlight->getId());
+            $highlightsIds[] = $highlight->getId();
         }
         return $highlightsIds;
     }
@@ -307,7 +307,7 @@ private function parsePages(): void
         $i = 0;
         foreach ($pageArray as $pages) {
             foreach ($pages as $page) {
-                array_push($this->pages, new Page($i, $page));
+                $this->pages[] = new Page($i, $page);
                 $i++;
             }
         }
@@ -328,7 +328,7 @@ private function parseRegions(): void
         $i = 0;
         foreach ($regionArray as $regions) {
             foreach ($regions as $region) {
-                array_push($this->regions, new Region($i, $region));
+                $this->regions[] = new Region($i, $region);
                 $i++;
             }
         }
@@ -349,7 +349,7 @@ private function parseHighlights(): void
         foreach ($highlightArray as $highlights) {
             foreach ($highlights as $highlight) {
                 foreach ($highlight as $hl) {
-                    array_push($this->highlights, new Highlight($hl));
+                    $this->highlights[] = new Highlight($hl);
                 }
             }
         }
@@ -369,7 +369,7 @@ private function getArrayByIndex(string $index): array
         $objectArray = [];
         foreach ($this->snippetsForRecord as $snippet) {
             if (!empty($snippet[$index])) {
-                array_push($objectArray, $snippet[$index]);
+                $objectArray[] = $snippet[$index];
             }
         }
         return $objectArray;

Classes/Controller/AbstractController.php

@@ -586,13 +586,13 @@ protected function buildSimplePagination(PaginationInterface $pagination, Pagina
         // page range
         for ($i = $nBottom; $i <= $nTop; $i++) {
             if ($i > 0 and $i <= $lastPage) {
-                array_push($aRange, $i);
+                $aRange[] = $i;
             };
         };
 
         // check whether the first screen page is > 1, if yes then points must be added
         if ($aRange[0] > 1) {
-            array_push($pagesSect, ['label' => '...','startRecordNumber' => '...']);
+            $pagesSect[] = ['label' => '...', 'startRecordNumber' => '...'];
         };
         $lastStartRecordNumberGrid = 0; // due to validity outside the loop
         foreach (range($firstPage, $lastPage) as $i) {
@@ -608,7 +608,7 @@ protected function buildSimplePagination(PaginationInterface $pagination, Pagina
                 // Check if screen page is in range
                 // <f:for each="{pagination.pagesR}" as="page">
                 if (in_array($i, $aRange)) {
-                    array_push($pagesSect, ['label' => $i, 'startRecordNumber' => $i]);
+                    $pagesSect[] = ['label' => $i, 'startRecordNumber' => $i];
                 };
             } else { // GridView
                 // to calculate the values for generation the links for the pagination pages
@@ -635,15 +635,15 @@ protected function buildSimplePagination(PaginationInterface $pagination, Pagina
 
                 // Check if screen page is in range
                 if (in_array($i, $aRange)) {
-                    array_push($pagesSect, ['label' => $i,'startRecordNumber' => $startRecordNumber]);
+                    $pagesSect[] = ['label' => $i, 'startRecordNumber' => $startRecordNumber];
                 };
             };
         };
 
         // check whether the last element from $aRange <= last screen page, if yes then points must be added
         if ($aRange[array_key_last($aRange)] < $lastPage) {
-            array_push($pagesSect, ['label' => '...', 'startRecordNumber' => '...']);
-        };
+            $pagesSect[] = ['label' => '...', 'startRecordNumber' => '...'];
+        }
 
         // Safely get the next and previous page numbers
         $nextPageNumber = isset($pages[$currentPageNumber + 1]) ? $pages[$currentPageNumber + 1]['startRecordNumber'] : null;

Classes/Controller/SearchController.php

@@ -342,7 +342,7 @@ private function makeFacetsMenuArray(array $facets): array
                 'key' => $field,
                 'field' => $field,
                 'limit' => $this->settings['limitFacets'] ?? 15,
-                'sort' => isset($this->settings['sortingFacets']) ? $this->settings['sortingFacets'] : 'count'
+                'sort' => $this->settings['sortingFacets'] ?? 'count'
             ];
         }