Fix ModuleNotFoundError with setuptools 80.2.0 or higher. #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample error:
```
.tox/py312/lib/python3.12/site-packages/mr/developer/extension.py:2: in <module>
from setuptools.package_index import safe_name
E ModuleNotFoundError: No module named 'setuptools.package_index'
```
`setuptools` 80.2.0 removes the `package_index` module.
When it still existed, this actually imported `safe_name` from `pkg_resources`.
This may depend on the setuptools version as well, and `pkg_resources` will be removed at the end of the year.
So I copied the only thing we needed: the `safe_name` function.
|
Looks good to me. Feel free to merge whenever it fits. |
fschulze
approved these changes
Jun 4, 2025
|
Thanks for the quick review. I have released 2.0.3 with this. |
|
thanks to both of you |
mauritsvanrees
added a commit
to zopefoundation/Zope
that referenced
this pull request
Jun 10, 2025
This fixes a ModuleNotFoundError with setuptools 80.2 or higher, for the removed `package_index` module. See fschulze/mr.developer#213
mauritsvanrees
added a commit
to zopefoundation/Zope
that referenced
this pull request
Jun 10, 2025
This fixes a ModuleNotFoundError with setuptools 80.2 or higher, for the removed `package_index` module. See fschulze/mr.developer#213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample error:
setuptools80.2.0 removes thepackage_indexmodule. When it still existed, this actually importedsafe_namefrompkg_resources. This may depend on the setuptools version as well, andpkg_resourceswill be removed at the end of the year. So I copied the only thing we needed: thesafe_namefunction.Note that we don't have CI setup on master currently. But @mamico has added that in PR #212. So we should get that PR merged soon as well. (And I would also fully drop Python 2 support, and Python 3.8 and lower.)