Fix flaky test: auto-generated IDs colliding with hardcoded vahter IDs#112
Merged
Fix flaky test: auto-generated IDs colliding with hardcoded vahter IDs#112
Conversation
The shared ID counter in TgMessageUtils started at 1, so auto-generated user IDs could reach 34 or 69 (the hardcoded vahter IDs). When this happened, isBanAuthorized silently rejected the ban (can't ban a vahter), causing "Vahter can unban user" to fail intermittently depending on test collection execution order. Fix: - Bump counter start to 100000 to avoid all hardcoded IDs - Add /unbanChatMember to FakeTgApi (was returning 500) - Add verbose console logger to CI so test execution order is visible Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared ID counter in TgMessageUtils started at 1, so auto-generated user IDs could reach 34 or 69 (the hardcoded vahter IDs). When this happened, isBanAuthorized silently rejected the ban (can't ban a vahter), causing "Vahter can unban user" to fail intermittently depending on test collection execution order.
Fix: