Created a fork #51
Closed
Created a fork #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess the links broke with df7afd4
Needs now FSharp.Core >= 5.0.0 instead of 5.0.1
I'm not using GitPod therefore it is not possible to test it enough for now.
Collaborator
|
I don't mind to add some features like support for |
Contributor
Author
|
That's totally fine with me! I didn't expect you to adjust to my personal style of programming. I opened another PR with the ResizeArray support only: #57 I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I hope this is okay, but I forked the project, started to make changes I wanted for my projects and added my style to the current implementation. I also created a Nuget release of my version, I hope I credited you right.
If there are problems with what I'm doing, please tell me so I can solve those!
I don't want to offend anyone but because the projects seems to be in a sleeping state right now, I thought I can create my own version for now.
I'm happy to contribute my changes back, but at the moment this is a little too much work, because one of the first things I did was to reformat the code with Fantomas, so I could not cherry-pick individual additions into own branches and MRs, that's why I'm opening this big one, if you are interested in what I'm doing.
Sorry for the wall of text!