RedundantNewKeyword: don't error if part of use binding #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that using the 'use' keyword on a non-IDisposable type would be flagged by the F# compiler as an (FS0193) error, we should assume that the type implements IDisposable when this keyword is present (because it's logical to assume that you run FSharpLint as an extra layer of correctness on top of compilation itself). Co-authored-by: webwarrior-ws <[email protected]>
If object is created using `new` keyword as a part of `use` binding, don't apply the rule, because only types that implement IDisposable can be used in `use` bindings.
Unlike with `use`, in case of `let` binding, usage of `new` on unresolved type should fire the rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that using the 'use' keyword on a non-IDisposable type would be flagged by the F# compiler as an (FS0193) error, we should assume that the type implements IDisposable when this keyword is present (because it's logical to assume that you run FSharpLint as an extra layer of correctness on top of compilation itself).