PIP-432: Add isEncrypted field to EncryptionContext #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements PIP-432 by adding an isEncrypted field to the EncryptionContext type to indicate whether a message is actually encrypted or was decrypted successfully. This provides API consumers with visibility into the encryption state of messages.
- Adds
IsEncryptedboolean field toEncryptionContexttype - Updates
FromMetadatamethod to accept anisEncryptedparameter - Updates consumer implementation to pass encryption state through the message processing pipeline
- Adds comprehensive test coverage to verify the
IsEncryptedfield behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Pulsar.Client/Common/DTO.fs | Adds IsEncrypted field to EncryptionContext and updates factory method |
| src/Pulsar.Client/Internal/ConsumerImpl.fs | Updates message processing to track and pass encryption state |
| tests/IntegrationTests/MessageCrypto.fs | Adds test function to verify IsEncrypted field and updates existing tests |
Comments suppressed due to low confidence (1)
tests/IntegrationTests/MessageCrypto.fs:110
- The test assumes all messages should be unencrypted (
IsEncrypted = false) but doesn't test the case where messages are actually encrypted. Consider adding a separate test function to verifyIsEncrypted = truefor encrypted messages.
failwith $"Message {i} should not be encrypted, but IsEncrypted = true"
Lanayx
approved these changes
Jul 30, 2025
RobertIndie
added a commit
to RobertIndie/pulsar-client-dotnet
that referenced
this pull request
Jul 31, 2025
* PIP-432: Add isEncrypted field to EncryptionContext * Add doc for EncryptionContext.IsEncrypted (cherry picked from commit 1eae9d1)
Lanayx
pushed a commit
that referenced
this pull request
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bring apache/pulsar#24481 to Pulsar.Client
Please see more details in the PIP-432