Open
Conversation
test classes for group course division and slot assignment
Added testing instructions
…ests' into feat/dev-division-tests
…achen/portals into feat/dev-division-tests
- updated CI for testing
test classes for group course division and slot assignment
Added testing instructions
- updated CI for testing
…ests' into feat/dev-division-tests
…at/dev-group-division-tests
- removed Unit testsuite - removed env-variables for CI-test (those are in phpunit.xml)
simonostendorf
requested changes
Sep 10, 2024
TitusKirch
suggested changes
Sep 12, 2024
tests/Feature/SlotAssignmentTest.php
Outdated
| }); | ||
|
|
||
| test('reassign after new registrations', function () { | ||
| $reg_amount = 5; |
Contributor
There was a problem hiding this comment.
This should be in camelCase, as this is what we primarily use.
tests/Feature/SlotAssignmentTest.php
Outdated
|
|
||
| test('reassign after new registrations', function () { | ||
| $reg_amount = 5; | ||
| $reg_amount_later = 12; |
Contributor
There was a problem hiding this comment.
This should be in camelCase, as this is what we primarily use.
tests/Feature/SlotAssignmentTest.php
Outdated
| $reg_amount = 5; | ||
| $reg_amount_later = 12; | ||
|
|
||
| createUsers($reg_amount); |
Contributor
There was a problem hiding this comment.
This should be in camelCase, as this is what we primarily use.
tests/Feature/SlotAssignmentTest.php
Outdated
| $this->assignment->assign(); | ||
|
|
||
| // queue position should be null for all registrations | ||
| expect($this->slot->registrations()->where('queue_position', null)->get()->count())->toEqual($reg_amount); |
Contributor
There was a problem hiding this comment.
This should be in camelCase, as this is what we primarily use.
tests/Feature/SlotAssignmentTest.php
Outdated
| // queue position should be null for all registrations | ||
| expect($this->slot->registrations()->where('queue_position', null)->get()->count())->toEqual($reg_amount); | ||
|
|
||
| createUsers($reg_amount_later); |
Contributor
There was a problem hiding this comment.
This should be in camelCase, as this is what we primarily use.
- made tests for group division more random
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
written in PHP Pest framework. CI runs new tests automatically