Skip to content

Fixed weakref async credential close when self.credential is None #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Fixed weakref async credential close when self.credential is None #330

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
180bcfc
Fixed bug with anon False in Windows 10
Jun 29, 2022
cad54f2
Added sync_credential in windows condition
Jun 29, 2022
b0dcf05
Added credential close
Jun 29, 2022
6a80daa
Added credential close
Jun 29, 2022
206524d
Remove unnecessary closures
Jun 29, 2022
b7a8967
Added right closures
Jun 29, 2022
68622ed
Added close credential async
Jun 29, 2022
9d5283f
Changed default azure credential place to init function
Jun 30, 2022
ae8702f
Added docstring in default azure credential
Jun 30, 2022
223d668
Remove unusued platform import
Jun 30, 2022
79f0500
Fixed docstring
Jun 30, 2022
d0f45ff
Added last line of code
Jun 30, 2022
381e236
Fixing pre-commit claims
Jul 11, 2022
1b7af6d
Fixed finalize credential None
Jul 23, 2022
4474652
Merge branch 'fsspec:main' into master
gabrieldaiha Jul 23, 2022
d2a5be6
Fixed finalize credential None
Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion adlfs/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,9 @@ def __init__(

self.do_connect()
weakref.finalize(self, sync, self.loop, close_service_client, self)
weakref.finalize(self, sync, self.loop, close_credential, self)

if self.credential is not None:
weakref.finalize(self, sync, self.loop, close_credential, self)

@classmethod
def _strip_protocol(cls, path: str):
Expand Down