Skip to content

Apply ruff/flake8-type-checking rules (TCH) #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Apply ruff/flake8-type-checking rules (TCH) #1718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d62973b
Apply ruff/flake8-type-checking rule TCH003
DimitriPapadopoulos Oct 12, 2024
2bd457d
Enforce ruff/flake8-type-checking rules (TCH)
DimitriPapadopoulos Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fsspec/implementations/tests/test_tar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import tarfile
import tempfile
from io import BytesIO
from pathlib import Path
from typing import TYPE_CHECKING

import pytest

Expand All @@ -15,6 +15,9 @@
from fsspec.implementations.tar import TarFileSystem
from fsspec.implementations.tests.test_archive import archive_data, temptar

if TYPE_CHECKING:
from pathlib import Path


def test_info():
with temptar(archive_data) as t:
Expand Down
3 changes: 2 additions & 1 deletion fsspec/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import logging
import math
import os
import pathlib
import re
import sys
import tempfile
Expand All @@ -24,6 +23,8 @@
from urllib.parse import urlsplit

if TYPE_CHECKING:
import pathlib

from typing_extensions import TypeGuard

from fsspec.spec import AbstractFileSystem
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ select = [
"SIM",
"SLOT",
"SIM101",
"TCH",
"UP",
]
ignore = [
Expand Down
Loading