Skip to content

Fix performance issues with MemoryFileSystem.rm #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix performance issues with MemoryFileSystem.rm #1725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions fsspec/implementations/memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,21 +248,25 @@ def created(self, path):
except KeyError:
raise FileNotFoundError(path)

def isfile(self, path):
path = self._strip_protocol(path)
return path in self.store

def rm(self, path, recursive=False, maxdepth=None):
if isinstance(path, str):
path = self._strip_protocol(path)
else:
path = [self._strip_protocol(p) for p in path]
paths = self.expand_path(path, recursive=recursive, maxdepth=maxdepth)
for p in reversed(paths):
if self.isfile(p):
self.rm_file(p)
# If the expanded path doesn't exist, it is only because the expanded
# path was a directory that does not exist in self.pseudo_dirs. This
# is possible if you directly create files without making the
# directories first.
if not self.exists(p):
elif not self.exists(p):
continue
if self.isfile(p):
self.rm_file(p)
else:
self.rmdir(p)

Expand Down
Loading