Skip to content

Add newline inclusive disclaimer #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add newline inclusive disclaimer #1770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fsspec/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2131,7 +2131,7 @@ def readuntil(self, char=b"\n", blocks=None):
return b"".join(out)

def readline(self):
"""Read until first occurrence of newline character
"""Read until and including the first occurrence of newline character

Note that, because of character encoding, this is not necessarily a
true line ending.
Expand All @@ -2148,7 +2148,7 @@ def __iter__(self):
return self

def readlines(self):
"""Return all data, split by the newline character"""
"""Return all data, split by the newline character, including the newline character"""
data = self.read()
lines = data.split(b"\n")
out = [l + b"\n" for l in lines[:-1]]
Expand Down
Loading