add positional argument #1820
Merged
add positional argument #1820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add documentation to the method, that this is always actually recursive, and the value of the argument makes no difference. |
martindurant
reviewed
Apr 3, 2025
martindurant
reviewed
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compatibility issue with PyTorch Geometric
The current implementation of LocalFileSystem.mv() was causing "TypeError: takes 3 positional arguments but 4 were given" when called from PyTorch Geometric's fs.py.
This PR explicitly adds the
recursiveparameter to the method signature, allowing it to be properly called with this parameter without causing positional argument errors.