Skip to content

Improve CachingFileSystem performance #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
+12 −0
Merged

Improve CachingFileSystem performance #1833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions fsspec/implementations/cached.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,11 @@ def _open(
self._metadata.update_file(path, detail)
logger.debug("Creating local sparse file for %s", path)

# explicitly submitting the size to the open call will avoid extra
# operations when opening. This is particularly relevant
# for any file that is read over a network, e.g. S3.
size = detail.get("size", None)

# call target filesystems open
self._mkcache()
f = self.fs._open(
Expand All @@ -344,8 +349,15 @@ def _open(
autocommit=autocommit,
cache_options=cache_options,
cache_type="none",
size=size,
**kwargs,
)

# set size if not already set
if size is None:
detail["size"] = f.size
self._metadata.update_file(path, detail)

if self.compression:
comp = (
infer_compression(path)
Expand Down
Loading