Apply Sourcery suggestions and fix typos #1863
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
force-pushed
the
sourcery
branch
2 times, most recently
from
106f22d to
1d1547b
Compare
DimitriPapadopoulos
force-pushed
the
sourcery
branch
from
1d1547b to
28232e9
Compare
|
I'm not convinced that every change is an improvement, but it all seems to be OK. Are you planning to do more work here? |
|
Do you have in mind the changes from I don't intend adding more changes (although Sourcery suggests more). I do think it might be worthwhile to add Sourcery to the repository, it provides AI assistance for PR review. I find it useful, although not bulletproof or astounding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.