Skip to content

Conversation

ReubenFrankel
Copy link
Contributor

Pass through kwargs to expand_path calls where possible to ensure they are propagated to ls implementation by default.

@martindurant
Copy link
Member

I agree, but is there any particular situation in which this was a problem for you, perhaps something that could be made into a test?

@ReubenFrankel
Copy link
Contributor Author

ReubenFrankel commented Sep 2, 2025

I think I was trying to use download/get and wanted to pass some kwargs through to my ls implementation, which required this change. Happy to write some tests -- would those fit best in fsspec/tests/test_spec.py?

@martindurant
Copy link
Member

Happy to write some tests -- would those fit best in fss spec/tests/test_spec.py

Yes, that would be fine. You will see that many of the general-purpose tests use one of the simpler filesystem implementations, though in this case you would need one that actually makes use of some kwarg.

@ReubenFrankel
Copy link
Contributor Author

@martindurant Let me know if this looks OK

@martindurant
Copy link
Member

I am happy to merge, it's up to you whether to keep the test or not.

@martindurant martindurant merged commit 7aa982a into fsspec:master Sep 16, 2025
17 of 20 checks passed
@ReubenFrankel ReubenFrankel deleted the fix/expand-path-kwargs branch September 16, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants