Use list form of fs.put()
in LocalTempFile to avoid isdir()
checks
#1920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling put with lists like
put([a], [b])
avoids the expensive path expansion in AbstractFileSystem/AsyncFileSystemfilesystem_spec/fsspec/spec.py
Lines 1049 to 1051 in 7aa982a
In particular this avoids calling
isdir()
which can be really expensive in object stores likegcsfs
. Concretely it saves 3 GET requests in each commit through a simplecache chained to gcsfs. See fsspec/gcsfs#702 for additional context.