Skip to content

Conversation

timkpaine
Copy link
Contributor

@timkpaine timkpaine commented Oct 16, 2025

  • async_wrapper was missing from known implementations and wrongly detected by regex logic in core
  • dirfs and async_wrapper marked as chained, chaining detection logic updated to pass in bit if its being used (in which case you need to pass args in via open)

I am validating largely by testing https://github.com/1kbgz/fsspec-union/blob/544723c93bc6d72071494c040d0c28edda5ee088/fsspec_union/tests/conftest.py#L10
which uses (abuses?) chaining to construct a read-through cache, and https://github.com/1kbgz/fsspec-python/blob/216dee3f3b95cd944910acca8b98626d4795ca9a/fsspec_python/tests/conftest.py#L63 which uses chaining to mount the fs as an import path.

@timkpaine timkpaine marked this pull request as draft October 16, 2025 05:08
@martindurant
Copy link
Member

I was wondering about this one. DirFS is not quite like the cachers, since the path is manipulated before being passed on. It sits somewhere between the cachers and archive FSs, so I'm not sure if it ought to be "chained".

Indeed, one failure appears, with URL "dir://afile::async_wrapper::file" that was probably caused by the change.

@timkpaine timkpaine marked this pull request as ready for review October 17, 2025 02:31
@timkpaine timkpaine changed the title Mark dir fs as chained Mark dir, async wrapper fs as chained Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants