Skip to content

Conversation

@AllanChain
Copy link
Contributor

Fixes #1977

The main logic is:

  • For r and a, try download first
  • For simple read and no update, open a regular file handler
  • For other cases, open a LocalTempFile

Some comments/questions:

  • I'm confused at kwargs["mode"] = mode line, seems that we should always open compressed files using rb?
  • I can't get open_many working for append. Seems the open_files passed to open_many is empty. This seems to be another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SimpleCacheFileSystem does not handle "a" or "r+" properly

1 participant