-
Notifications
You must be signed in to change notification settings - Fork 433
Apply lru_cache manually per LazyReferenceMapper instance
#1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+7
−4
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5a3c61b
Apply `lru_cache` manually per-instance
honzaflash 1bbfcc4
Remove B019 rule from ruff ignore list
honzaflash fa8742c
Use cached static helpers for `listdir` and `_key_to_record`
honzaflash e6da03e
Revert "Use cached static helpers for `listdir` and `_key_to_record`"
honzaflash eefb930
Merge branch 'master' into fix-lru-cache-methods
honzaflash 7088571
Add a comment about immutability assumption
honzaflash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, silly me, dictionaries are unhashable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more I look at this, the more I think the original simple solution might be the best.
Apparently, you can use
freezedictwhich is hashable, but that might be a problem because_get_chunk_sizesactually mutatesself.chunk_sizes(or more specifically adds a key-val pair to it, it should never mutate existing key).I think, assuming that the object attributes won't change once the cache entry has been saved might be the easiest way forward. Of course, we should note that in a comment. And go back to