Open
Conversation
Member
|
Please check failures in the "downstream" CI job. These use withdirs or maxdepth, so we may not h ave enough coverage in the tests here. Question: why are those two kwargs problematic in the presence of a prefix? |
Author
Good question. I've made a fix PR for s3fs, in which I learned that if you would naively do Both the downstream test and the s3fs test seem to fail on the same guard in S3FS; the one I now hope to resolve in fsspec/s3fs#1014. That PR is the one that should be reviewed (and merged) first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add support to fsspec to pass a prefix to supported backends.
What it does is extract the literal stem between the last / and the first wildcard character (, ?, [), and pass it as prefix= in the kwargs forwarded to _find. Backends that understand prefix=(gcsfs, adlfs, s3fs) use it to filter the listing server-side via the storage API's ?prefix= parameter. Backends that don't understand it receive it in kwargs and are expected to silently ignore it — no behaviour change for them.
*s3fs needs a fix to not break, and use the support; this PR should be considered blocked by it's support added. It may otherwise break implementations.
**expected: except s3fs all that I could find do; but I'm not sure what I'm missing..
closes #1995
To Do
_globperforms full directory/bucket scans - unnecessarily #1995