Skip to content

Improve folder detection in _info #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve folder detection in _info #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gcsfs/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,10 +814,10 @@ async def _info(self, path, **kwargs):
pass
kwargs["detail"] = True # Force to true for info
out = await self._ls(path, **kwargs)
out0 = [o for o in out if o["name"].rstrip("/") == path]
if out0:
out0 = next((o for o in out if o["name"].rstrip("/") == path), None)
if out0 and out0["name"][-1] != "/" and out0["size"] == 0:
Copy link
Member

@martindurant martindurant Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if out0 and out0["name"][-1] != "/" and out0["size"] == 0:
if out0 and (out0["name"][-1] != "/" or out0["size"] == 0):

# exact hit
return out0[0]
return out0
elif out:
# other stuff - must be a directory
return {
Expand Down