Skip to content

Rename read/write_fixed_duration to read/write#782

Merged
ankitaluthra1 merged 2 commits intofsspec:mainfrom
zhixiangli:docs/update-readme-groups
Apr 1, 2026
Merged

Rename read/write_fixed_duration to read/write#782
ankitaluthra1 merged 2 commits intofsspec:mainfrom
zhixiangli:docs/update-readme-groups

Conversation

@zhixiangli
Copy link
Copy Markdown
Contributor

@zhixiangli zhixiangli commented Mar 20, 2026

This PR renames read_fixed_duration and write_fixed_duration to read and write respectively within the microbenchmarks suite.

Changes include:

  • Renamed benchmark directories for read and write.
  • Renamed Configurators, BenchmarkParameters, and case generator functions for better brevity.
  • Updated all internal references in test_configs.py, test_run.py, and conftest.py.
  • Refreshed the microbenchmarks README.md to reflect the new naming convention.

@zhixiangli zhixiangli force-pushed the docs/update-readme-groups branch 2 times, most recently from 359df08 to b0b4a13 Compare March 31, 2026 10:47
@zhixiangli zhixiangli changed the title docs: Update microbenchmarks README with correct group examples refactor: rename read/write_fixed_duration to read/write Mar 31, 2026
@zhixiangli zhixiangli changed the title refactor: rename read/write_fixed_duration to read/write Rename read/write_fixed_duration to read/write Mar 31, 2026
@zhixiangli zhixiangli force-pushed the docs/update-readme-groups branch from b0b4a13 to c57ba44 Compare March 31, 2026 13:04
@ankitaluthra1
Copy link
Copy Markdown
Collaborator

/gcbrun

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.32%. Comparing base (1ec7a98) to head (f6c1c3b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
+ Coverage   75.96%   76.32%   +0.35%     
==========================================
  Files          14       14              
  Lines        2663     2665       +2     
==========================================
+ Hits         2023     2034      +11     
+ Misses        640      631       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhixiangli
Copy link
Copy Markdown
Contributor Author

/gcbrun

@ankitaluthra1
Copy link
Copy Markdown
Collaborator

/gcbrun

@ankitaluthra1 ankitaluthra1 merged commit d425e28 into fsspec:main Apr 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants