Update find cache and rm tests#797
Merged
ankitaluthra1 merged 7 commits intofsspec:mainfrom Mar 31, 2026
Merged
Conversation
Contributor
Mahalaxmibejugam
commented
Mar 30, 2026
Mahalaxmibejugam
commented
- Address cache inconsistency issues within the find method when utilizing maxdepth on Hierarchical Namespace (HNS) buckets
- Added a test that highlights an edge case where non-recursive wildcard removals targeting non-empty subdirectories trigger a precondition failure on HNS buckets (whereas Standard buckets handle it silently).
- Updated the documentation for HNS buckets to mention the edge case of rm with non-recursive.
- test_rm_wildcard_with_empty_folders for HNS - test_rm_wildcards_asterisk_non_recursive for HNS - test_rm_wildcards_and_lists for standard buckets
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
==========================================
+ Coverage 75.96% 76.32% +0.35%
==========================================
Files 14 14
Lines 2663 2665 +2
==========================================
+ Hits 2023 2034 +11
+ Misses 640 631 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
/gcbrun |
Collaborator
|
Please fix codecov/project failure or add a comment in case WAI |
Contributor
Author
PR was behind main by 2 commits, so coverage added in those 2 commits was not getting reflected in codecov/project run and hence it was showing as failure. I pulled the latest main in this PR now, so it should reflect the right coverage. |
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.