Skip to content

Add more specific version requirements for Zarr in pyproject.toml#541

Merged
martindurant merged 2 commits intofsspec:mainfrom
maxrjones:patch-1
Jan 30, 2025
Merged

Add more specific version requirements for Zarr in pyproject.toml#541
martindurant merged 2 commits intofsspec:mainfrom
maxrjones:patch-1

Conversation

@maxrjones
Copy link
Contributor

@maxrjones maxrjones commented Jan 30, 2025

Zarr Python 3 is needed, not >3

@martindurant
Copy link
Member

I'm not sure we wanted to allow ==3.0.0, I think we are depending on some fairly cutting edge things here

@TomNicholas
Copy link

Isn't the problem here that >3 implies zarr 4?? IIUC should either be >=3 or >3.0.0

@maxrjones
Copy link
Contributor Author

Isn't the problem here that >3 implies zarr 4?? IIUC should either be >=3 or >3.0.0

This is what I assumed too, but I think Martin could be right that 3.0.1 satisfies >3. I'm trying to find a primary source of guidance now.

@TomNicholas
Copy link

I think we are depending on some fairly cutting edge things here

Then just pin to the latest released version of zarr-python - the one you're presumably testing against? (Which is apparently only 3.0.1 anyway)

@maxrjones
Copy link
Contributor Author

I updated it to >=3.0.1 since it seems there was not typo, but being explicit about version requirements is helpful if kerchunk does rely on fixes between 3.0.0 and 3.0.1.

@maxrjones maxrjones changed the title Fix deps typo in pyproject.toml Add more specific version requirements for Zarr in pyproject.toml Jan 30, 2025
@TomNicholas
Copy link

That also seems consistent with what every other package that depends on zarr-python v3 is doing.

@martindurant martindurant merged commit c89f762 into fsspec:main Jan 30, 2025
4 checks passed
@maxrjones maxrjones deleted the patch-1 branch January 30, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants