Issue 559: Update scan_grib to store levels with two surfaces#560
Merged
martindurant merged 5 commits intofsspec:mainfrom Dec 18, 2025
Conversation
Update scan_grib to include evaluation of two-surface levels when determining if a message has levels
Member
|
I'm fine with this if it fits your use case. Can we include a docstring or comment in the new utility function to explain the why? Also, if you have a small public example file, we could include it for a test. |
Contributor
|
For reference (and for redundancy): this pull request addresses #559 |
Member
|
Thanks @krlor17 , I updated the PR description |
Member
|
Sorry, I completely stopped following this, is it ready now? |
Contributor
Author
|
Oh wow this completely dropped through the cracks, twice :O |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update scan_grib to include evaluation of two-surface levels when determining if a message has levels
Fixes #559