-
Notifications
You must be signed in to change notification settings - Fork 290
put_file: support concurrent multipart uploads with max_concurrency #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -235,6 +235,12 @@ class S3FileSystem(AsyncFileSystem): | |||||||||||||||||||||
session : aiobotocore AioSession object to be used for all connections. | ||||||||||||||||||||||
This session will be used inplace of creating a new session inside S3FileSystem. | ||||||||||||||||||||||
For example: aiobotocore.session.AioSession(profile='test_user') | ||||||||||||||||||||||
max_concurrency : int (None) | ||||||||||||||||||||||
If given, the maximum number of concurrent transfers to use for a | ||||||||||||||||||||||
multipart upload. Defaults to 1 (multipart uploads will be done sequentially). | ||||||||||||||||||||||
Note that when used in conjunction with ``S3FileSystem.put(batch_size=...)`` | ||||||||||||||||||||||
the result will be a maximum of ``max_concurrency * batch_size`` concurrent | ||||||||||||||||||||||
transfers. | ||||||||||||||||||||||
|
If given, the maximum number of concurrent transfers to use for a | |
multipart upload. Defaults to 1 (multipart uploads will be done sequentially). | |
Note that when used in conjunction with ``S3FileSystem.put(batch_size=...)`` | |
the result will be a maximum of ``max_concurrency * batch_size`` concurrent | |
transfers. | |
The maximum number of concurrent transfers to use per file for a | |
multipart upload (``put()``) operations. Defaults to 1 (sequential). | |
When used in conjunction with ``S3FileSystem.put(batch_size=...)`` | |
the maximum number of simultaneous connections is ``max_concurrency * batch_size``. | |
We may extend this parameter to affect ``pipe()``, ``cat()`` and ``get()``. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please rename this to indicate it is uploading from a file, as opposed to bytes. Or can it be generalised to support pipe()
too?
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not max_concurrency=1
as the default in __init__
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere we need a caveat, that increasing concurrency will lead to high memory use.
Uh oh!
There was an error while loading. Please reload this page.