Skip to content

try copy() instead of using shell cp #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

try copy() instead of using shell cp #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sshfs/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,12 @@ async def _get_file(

@wrap_exceptions
async def _cp_file(self, lpath, rpath, **kwargs):
# some SFTP servers support the copy-data extension
with suppress(SFTPOpUnsupported):
async with self._pool.get() as channel:
await channel.copy(lpath, rpath)
return

cmd = f"cp {shlex.quote(lpath)} {shlex.quote(rpath)}"
await self._execute(cmd)

Expand Down
Loading