Skip to content

Change protocol check to fallback for known implementations #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Change protocol check to fallback for known implementations #449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion upath/_flavour.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def from_protocol(
except KeyError:
pass
# finally fallback to a default flavour for the protocol
if protocol in known_implementations:
if protocol not in known_implementations:
warnings.warn(
f"Could not find default for known protocol {protocol!r}."
" Creating a default flavour for it. Please report this"
Expand Down