Skip to content

initiate Workflow.py#9

Open
mina1987 wants to merge 1 commit intoftl-toolbox:masterfrom
mina1987:master
Open

initiate Workflow.py#9
mina1987 wants to merge 1 commit intoftl-toolbox:masterfrom
mina1987:master

Conversation

@mina1987
Copy link

create Workflow.py, Variant.py, role.py, sample yaml file to read from (workflow.yaml)


import yaml

class Workflow:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think rather than Workflow we could call the entire object from #4 a WorkflowConfig which inherits from object.

class WorkflowConfig(object):
...

@abutcher
Copy link
Member

Hey @mina1987 thanks for the PR! I'd like to see this change become a generic representation of a WorkflowConfig object which is free of the openshift specific configurations in #4. I've added some comments, please let me know if you have any questions 😄

@mina1987
Copy link
Author

Thanks,
I will make the changes,

Mina

On Mon, Mar 28, 2016 at 2:11 PM, Andrew Butcher notifications@github.com
wrote:

Hey @mina1987 https://github.com/mina1987 thanks for the PR! I'd like
to see this change become a generic representation of a WorkflowConfig
object which is free of the openshift specific configurations in #4
#4. I've added some
comments, please let me know if you have any questions [image: 😄]


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants