Open
Conversation
radl97
force-pushed
the
refactor-theta-cfa-generator
branch
from
453d2e0 to
824c9f7
Compare
radl97
force-pushed
the
refactor-theta-cfa-generator
branch
from
824c9f7 to
26f5347
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
Refactored it, sorry |
sallaigy
requested changes
Feb 9, 2021
Member
sallaigy
left a comment
sallaigy
left a comment
There was a problem hiding this comment.
Looks good overall, I left some minor comments to tackle :)
| @@ -1,47 +0,0 @@ | |||
| main process __gazer_main_process { | |||
Member
There was a problem hiding this comment.
Thanks for removing this file. Could we perhaps add a .gitignore into test/theta so that the Output directory is ignored and we can avoid commiting files like this again?
Co-authored-by: Gyula Sallai <salla016@gmail.com>
radl97
force-pushed
the
refactor-theta-cfa-generator
branch
from
3660b54 to
8997e05
Compare
AdamZsofi
approved these changes
Feb 13, 2021
Member
AdamZsofi
left a comment
AdamZsofi
left a comment
There was a problem hiding this comment.
I couldn't find anything, that wasn't mentioned already, nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first patch aiming to enable generating Theta-XCFA.
This PR refactors the monolith that is ThetaCfaGenerator.