feat(tui): add support for named themes (#1779) - #1780
Draft
fujiapple852 wants to merge 1 commit into
Draft
Conversation
fujiapple852
marked this pull request as draft
April 5, 2026 08:43
fujiapple852
force-pushed
the
feat-themes-v2
branch
5 times, most recently
from
April 5, 2026 09:15
0fc2b57 to
324486e
Compare
Owner
Author
|
@PerchunPak this draft PR adds support for named themes. I took the liberty of adding the 4x themes you defined as well as adding the basic |
fujiapple852
force-pushed
the
feat-themes-v2
branch
from
April 5, 2026 09:19
324486e to
fa15363
Compare
fujiapple852
commented
Apr 5, 2026
| compare(parse_config(cmd), expected); | ||
| } | ||
|
|
||
| // TODO add --tui-theme tests |
fujiapple852
commented
Apr 5, 2026
| tui_max_addrs: Some(super::constants::DEFAULT_TUI_MAX_ADDRS), | ||
| tui_locale: None, | ||
| tui_timezone: None, | ||
| tui_theme: Some(String::from(super::constants::DEFAULT_TUI_THEME)), |
fujiapple852
commented
Apr 5, 2026
| } | ||
|
|
||
| impl Default for TuiTheme { | ||
| // TODO: expect here |
fujiapple852
commented
Apr 5, 2026
| .iter() | ||
| .map(|(name, source)| { | ||
| let theme: TuiTheme = toml::from_str(source).unwrap_or_else(|err| { | ||
| // TODO panic here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1779