Use non-root user and group in default for Docker images.#75
Merged
fujitatomoya merged 2 commits intorollingfrom Dec 4, 2025
Merged
Use non-root user and group in default for Docker images.#75fujitatomoya merged 2 commits intorollingfrom
fujitatomoya merged 2 commits intorollingfrom
Conversation
fujitatomoya
force-pushed
the
docker-image-non-root
branch
from
f90543e to
f0907e2
Compare
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
force-pushed
the
docker-image-non-root
branch
from
f0907e2 to
6dc0b78
Compare
There was a problem hiding this comment.
Pull request overview
This PR enhances Docker image security by switching from running containers as root to using a non-root user ros2ai. The changes update default workspace paths and user configurations across the Dockerfile and related scripts.
Key Changes:
- Introduces non-root user
ros2aiwith configurable UID/GID in the Dockerfile - Updates default workspace path from
/root/colcon_wsto/home/ros2ai/colcon_ws - Adds environment variables to README docker run example for better documentation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docker/Dockerfile | Creates non-root user with sudo privileges, updates workspace paths, and sets proper file ownership |
| scripts/docker_release.sh | Updates paths to reference new non-root user's home directory and workspace location |
| README.md | Adds OPENAI_ENDPOINT and OPENAI_MODEL_NAME environment variables to docker run command example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Owner
Author
|
@copilot can you approve this? |
|
@fujitatomoya I've opened a new pull request, #76, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #70