Skip to content

remove Ollama dependency.#78

Merged
Barry-Xu-2018 merged 1 commit intorollingfrom
remove-ollama-dependency
Dec 12, 2025
Merged

remove Ollama dependency.#78
Barry-Xu-2018 merged 1 commit intorollingfrom
remove-ollama-dependency

Conversation

@fujitatomoya
Copy link
Owner

@fujitatomoya fujitatomoya commented Dec 11, 2025

Since ros2ai uses the OpenAI API interface and doesn't directly depend on ollama's interfaces, this dependency can be removed.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@github-actions
Copy link

There is a problem with the Gemini CLI PR review. Please check the action logs for details.

@fujitatomoya
Copy link
Owner Author

@Barry-Xu-2018 can you approve this?

Copy link
Collaborator

@Barry-Xu-2018 Barry-Xu-2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Readme needs to be updated later. If users want to use Ollama, they need to install the required Python dependencies themselves.

@fujitatomoya
Copy link
Owner Author

If users want to use Ollama, they need to install the required Python dependencies themselves.

is that what they really need? i do not think user application needs python ollama package at all, but just ollama debian server package to run ollama server to provide the endpoint?

@Barry-Xu-2018
Copy link
Collaborator

If users want to use Ollama, they need to install the required Python dependencies themselves.

is that what they really need? i do not think user application needs python ollama package at all, but just ollama debian server package to run ollama server to provide the endpoint?

My understanding is that it is necessary to install the Ollama Python package because it provides the Ollama client, which is responsible for communicating with the Ollama server. Is my understanding correct?

@fujitatomoya
Copy link
Owner Author

No, ros2ai only uses openai python package to access the endpoint. and ollama server provides the same APIs on the endpoint, so the python client in this case ros2ai does just use the same code via openai to call the ollama endpoint. that is the reason i said we do not need to ollama python package in package.xml. user is responsible to run ollama server when they need to use ollama endpoint.

@Barry-Xu-2018
Copy link
Collaborator

No, ros2ai only uses openai python package to access the endpoint. and ollama server provides the same APIs on the endpoint, so the python client in this case ros2ai does just use the same code via openai to call the ollama endpoint. that is the reason i said we do not need to ollama python package in package.xml. user is responsible to run ollama server when they need to use ollama endpoint.

Thank you for your explanation, I understand now.

@Barry-Xu-2018 Barry-Xu-2018 merged commit 821ab70 into rolling Dec 12, 2025
8 of 9 checks passed
@Barry-Xu-2018 Barry-Xu-2018 deleted the remove-ollama-dependency branch December 12, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants