fix: guard against missing MC tag in allele frequency calculation#58
fix: guard against missing MC tag in allele frequency calculation#58
Conversation
src/main/scala/com/fulcrumgenomics/sv/tools/AggregateSvPileup.scala
Outdated
Show resolved
Hide resolved
8b801d3 to
edb5140
Compare
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d63ed81 to
a4edb83
Compare
src/main/scala/com/fulcrumgenomics/sv/tools/AggregateSvPileup.scala
Outdated
Show resolved
Hide resolved
…uency calculation The mateEnd.get call in numOverlappingTemplates would throw a bare NoSuchElementException when the BAM file lacks MC (mate CIGAR) tags. Replace with getOrElse that raises an IllegalStateException with a clear message directing users to add MC tags (e.g. via samtools fixmate). Keep checkAsPair unchanged since it does not access mateEnd.
20cbb59 to
48b6570
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
rec.mateEnd.isDefinedcheck tocheckAsPairinAggregateSvPileup.numOverlappingTemplatesNoSuchElementExceptionwhen BAM files lack the MC (mate CIGAR) tag, which is needed to derivemateEndTest plan
./mill tools.test)