Skip to content

fix: sort aggregated pileup IDs numerically instead of lexicographically#63

Merged
nh13 merged 2 commits intomainfrom
fix/aggregate-pileup-id-sorting
Feb 21, 2026
Merged

fix: sort aggregated pileup IDs numerically instead of lexicographically#63
nh13 merged 2 commits intomainfrom
fix/aggregate-pileup-id-sorting

Conversation

@nh13
Copy link
Member

@nh13 nh13 commented Feb 20, 2026

Summary

  • Compound breakpoint IDs in AggregatedBreakpointPileup were sorted as strings, producing non-intuitive ordering (e.g. "112_456_5_7_8_9" instead of "5_7_8_9_112_456")
  • Change pileupIds() and add() to use sortBy(_.toInt) for numeric ordering
  • Update test expectations to match new numeric ordering

Test plan

  • Existing tests pass with updated expectations (./mill tools.test)

@nh13 nh13 requested review from clintval and tfenne as code owners February 20, 2026 21:53
@clintval
Copy link
Member

May also help with determinism. Thanks!

@nh13 nh13 force-pushed the fix/aggregate-pileup-id-sorting branch from e722532 to 206f472 Compare February 21, 2026 01:56
@coderabbitai
Copy link

coderabbitai bot commented Feb 21, 2026

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/aggregate-pileup-id-sorting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nh13 nh13 force-pushed the fix/aggregate-pileup-id-sorting branch 3 times, most recently from 98e1dce to 8dc6371 Compare February 21, 2026 06:02
Compound breakpoint IDs were sorted as strings, causing non-intuitive
ordering (e.g. "112_456_5_7_8_9" instead of "5_7_8_9_112_456").
Change to numeric sorting via sortBy(_.toInt) for consistency.
@nh13 nh13 force-pushed the fix/aggregate-pileup-id-sorting branch from 9bcb612 to 77ca3f0 Compare February 21, 2026 06:04
@nh13 nh13 merged commit 81ec5c2 into main Feb 21, 2026
1 check passed
@nh13 nh13 deleted the fix/aggregate-pileup-id-sorting branch February 21, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants