fix: sort aggregated pileup IDs numerically instead of lexicographically#63
fix: sort aggregated pileup IDs numerically instead of lexicographically#63
Conversation
|
May also help with determinism. Thanks! |
e722532 to
206f472
Compare
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
98e1dce to
8dc6371
Compare
Compound breakpoint IDs were sorted as strings, causing non-intuitive ordering (e.g. "112_456_5_7_8_9" instead of "5_7_8_9_112_456"). Change to numeric sorting via sortBy(_.toInt) for consistency.
9bcb612 to
77ca3f0
Compare
Summary
AggregatedBreakpointPileupwere sorted as strings, producing non-intuitive ordering (e.g."112_456_5_7_8_9"instead of"5_7_8_9_112_456")pileupIds()andadd()to usesortBy(_.toInt)for numeric orderingTest plan
./mill tools.test)