Skip to content

Conversation

@fulldecent
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings December 5, 2025 01:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the testing infrastructure and updates iOS version support. The changes rename "master" to "main" throughout, document command-line testing procedures, update CI to use newer build environments, and clean up funding links.

Key changes:

  • Updated GitHub Actions CI to use macOS 15, Xcode 16.4, and iOS 18.5 simulators
  • Added comprehensive testing documentation in README with command-line examples
  • Set Example app deployment target to iOS 18.6

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Added testing section with command-line build/test instructions, removed tip jar link, updated template reference to swift6
Example/Example.xcodeproj/project.pbxproj Updated iOS deployment target to 18.6 for both Debug and Release configurations
CHANGELOG.md Reformatted with consistent markdown headers, updated branch reference from "Master" to "Main"
.github/workflows/test.yml Upgraded CI to macos-15 runner, Xcode 16.4, and iPhone 16 with iOS 18.5; split build and test into separate steps
.github/FUNDING.yml Removed Amazon wishlist funding link, kept PayPal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +86 to +93
xcodebuild build -scheme FDWaveformView -destination 'id=XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX'

# Run unit tests
xcodebuild test -scheme FDWaveformView -destination 'id=XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX'

# Build the Example app (requires a newer iOS simulator)
cd Example
xcodebuild build -scheme Example -destination 'id=XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX'
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example uses a placeholder UUID XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX which users need to replace. Consider adding a note above or in comments explaining that users should replace this with their actual simulator ID from the previous command.

Copilot uses AI. Check for mistakes.
@fulldecent fulldecent merged commit 7ff57c8 into main Dec 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants