Skip to content

Conversation

@weaponmasterjax
Copy link
Contributor

Pull request checklist

  • [y] The PR has a proper title. Use Semantic Commit Messages. (No more branch-name title please)
  • [y] Make sure you are requesting the right branch: dev.
  • [y] Make sure this is ready to be merged into the relevant branch. Please don't create a PR and let it hang for a few days.
  • [y] Ensure all tests are passing.
  • [y] Ensure linting is passing.

PR type

  • chore

Description

  • Update instructions for ROCM since ROCM now fully supports PyTorch, and it is confirmed that a drop-in replacement of PyTorch to the ROCM version will work. This will enable AMD GPU acceleration in more scenarios.
  • Do to the complexity of dependencies it's easier to just replace the existing CUDA torch installation with ROCM ones afterwards, rather than doing that again after PyTorch being overwritten in the process of pip install -r requirements.txt .

Copy link
Owner

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fumiama fumiama enabled auto-merge (squash) January 29, 2025 05:40
@fumiama fumiama merged commit 78dfad6 into fumiama:dev Jan 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants