Use cached value in derived atom watcher#3
Open
davidwalker wants to merge 1 commit intofuncool:masterfrom
Open
Use cached value in derived atom watcher#3davidwalker wants to merge 1 commit intofuncool:masterfrom
davidwalker wants to merge 1 commit intofuncool:masterfrom
Conversation
Avoids recalculating the previous value using selector if the cache already contains the correct value. Uses the same code as -deref to establish validity of cache value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change avoids recalculating
old-valueusing theselectorfn ifcachealready contains the correct value. For expensive selector functions this can have a big impact on performance.It uses the same code as is used in
-derefto establish validity of the cached value.I saw there was previously code which attempted to use the cache in watchers but it was removed in df32b5a with a comment that it caused race conditions in some situations.
I think there were two issues with the previous code that aren't present in this change:
srccachevalue matched theold-source-valuewhich could result in an incorrect cache value being used.