Open
Conversation
Contributor
|
ミニマムサクセスだけじゃなくてスタンダードもやってくださいね.ミニマムは研究を進めていくための必要条件というだけで,自分の研究を対外的に説明するとか読み物としてまとめる時は,深く広い理解が必要です.(UKRのスタンダードが終わってないならUKRのスタンダードからやるのは一つありです) |
nahoando
reviewed
May 17, 2022
Contributor
nahoando
left a comment
There was a problem hiding this comment.
wiki,readmeを参考に自分の中でのミニマム、スタンダード、エクストラの設定をしておきましょう。UKRで確認し損ねた内容があるならそちらも一緒に確認してみるといいですね。作業にひと段落ついたらプッシュをするのを忘れずに!
Contributor
Author
Contributor
Author
Contributor
Author
Contributor
Contributor
Author
UKR.1.mp4 |
Contributor
|
観測空間のほうが描画されてないですが,写像がちゃんと$f(u_i, v_j) = x_{ij}$のようにデータ点に近くになっていることはどうやって確認していますか? |
Contributor
Author
TUKR.mp4 |
TetraMiyazaki
suggested changes
Jun 3, 2022
Contributor
TetraMiyazaki
left a comment
There was a problem hiding this comment.
ここで,ユーザーの潜在空間と商品の潜在空間は別物だからcolormap1, 2と用意するのはいいことですが,結局いれているのは青 -> 緑の値のrgb をいれていることになるので,もったいないです.それぞれちゃんと rgb用意してあげるといいですよ.
colormap = X[:, :, 0]
colormap1 = U[:, 0]
colormap2 = V[:, 0]
TetraMiyazaki
suggested changes
Jun 3, 2022
Contributor
TetraMiyazaki
left a comment
There was a problem hiding this comment.
#15 (review)
ここが解決したらapproveします
Contributor
Author
TUKR2.mp4 |
TetraMiyazaki
previously approved these changes
Jun 7, 2022
Contributor
TetraMiyazaki
left a comment
There was a problem hiding this comment.
色付けできたみたいなのでApproveします
Contributor
|
ローカルでcoflictを頑張って解決する必要がありそうですね |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




る。