Refactor code into a Python module#19
Open
nickswalker wants to merge 1 commit intofurushchev:masterfrom
Open
Conversation
Move classes into their own files in a module Adopt standard catkin support for the module so that other packages can use the wrappers directly
Owner
|
@nickswalker Thank you for sending PR! I still don't try your patch, but isn't this PR deleting executable from the package, which means the node is unable to be executed from launch file or with |
nickswalker
commented
Feb 10, 2020
| from respeaker_ros import RespeakerNode | ||
|
|
||
| if __name__ == '__main__': | ||
| rospy.init_node("respeaker_node") |
Author
There was a problem hiding this comment.
@furushchev Most of the code in this file was moved into node.py inside the module (to let people import and customize the node in their own packages). Because the diff was large GitHub collapsed it making it look like the file was removed completely, but it's still here, just very small now.
nickswalker
added a commit
to hcrlab/respeaker_ros
that referenced
this pull request
Aug 29, 2023
Matches the API of furushchev/respeaker_ros#19, but bumped to Python3 and with less string-y handling of audio data Drops dynamic reconfigure, as params are dynamic by default in ROS 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will let people import the RespeakerInterface and RespeakerAudio classes in code they write inside other packages. This is accomplished by using catkin's support for installing a package's Python modules.