Fix 16-bit image loading returning flat 1D array#1144
Open
muzman123 wants to merge 2 commits intofury-gl:v2from
Open
Fix 16-bit image loading returning flat 1D array#1144muzman123 wants to merge 2 commits intofury-gl:v2from
muzman123 wants to merge 2 commits intofury-gl:v2from
Conversation
Contributor
|
Hi @muzman123 , |
Author
|
Hey, just added a test for 16 bit image loading, added it in test_io.py as that is where all the other image loading tests exist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
image.reshape().astype()on line 122 offury/io.pyreturns a new array, but the result was never assigned back toimage, so the reshaped array was silently discardedimage =so the properly shaped array is kept