Fix: Panel2D crashes when used without borders (#1155)#1156
Open
JigyasuRajput wants to merge 1 commit intofury-gl:v2from
Open
Fix: Panel2D crashes when used without borders (#1155)#1156JigyasuRajput wants to merge 1 commit intofury-gl:v2from
JigyasuRajput wants to merge 1 commit intofury-gl:v2from
Conversation
Guard all self.borders references with self.has_border checks in _get_actors, _update_actors_position, update_border_coords, border_color, and border_width properties.
| actors = [] | ||
|
|
||
| actors.extend(self.background.actors) | ||
| for border in self.borders.values(): |
There was a problem hiding this comment.
self.borders.value = borders.value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1155
This pull request improves the robustness of the
Panel2DUI container when borders are disabled (has_border=False). Several methods now safely handle the absence of borders, preventing potential errors and ensuring consistent behavior. Additionally, a new test verifies thatPanel2Dfunctions correctly without borders.Robustness improvements for borderless
Panel2D:_get_actors,_update_actors_position,update_border_coords,border_color, andborder_widthto ensure they handle the case wherehas_borderisFalse, returning empty lists or exiting early as appropriate. [1] [2] [3] [4] [5] [6] [7]Testing improvements:
test_panel2d_no_border_actors_and_sceneto verify thatPanel2Dcan be used without borders, including adding actors, updating positions, adding to a scene, and accessing border properties without errors.Guard all self.borders references with self.has_border checks in _get_actors, _update_actors_position, update_border_coords, border_color, and border_width properties.